huaxingao commented on code in PR #56453:
URL: https://github.com/apache/spark/pull/56453#discussion_r3398321359
##########
dev/make-distribution.sh:
##########
@@ -259,9 +268,14 @@ if [ "$MAKE_PIP" == "true" ]; then
pushd "$SPARK_HOME/python" > /dev/null
# Delete the egg info file if it exists, this can cache older setup files.
rm -rf pyspark.egg-info || echo "No existing egg info file, skipping
deletion"
+ # Ship the Apache LICENSE and NOTICE inside the PySpark source distributions
+ # (see MANIFEST.in). These are removed again after the sdists are built.
+ cp "$SPARK_HOME/LICENSE" LICENSE
Review Comment:
Done. Switched the classic sdist to the -binary variants (and
licenses-binary).
##########
dev/make-distribution.sh:
##########
@@ -32,6 +32,15 @@ set -x
SPARK_HOME="$(cd "`dirname "$0"`/.."; pwd)"
DISTDIR="$SPARK_HOME/dist"
+# The Apache LICENSE and NOTICE are copied into the Python and R package
+# directories below so they are bundled into the source distributions. Remove
+# them on exit so a failed build does not leave stray files behind.
+function cleanup_dist_license_files {
+ rm -f "$SPARK_HOME/python/LICENSE" "$SPARK_HOME/python/NOTICE" \
Review Comment:
Done. Added `LICENSE/NOTICE` to `python/.gitignore` and
`pkg/LICENSE`/`pkg/NOTICE` to `R/.gitignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
