cloud-fan commented on code in PR #56291: URL: https://github.com/apache/spark/pull/56291#discussion_r3399806528
########## sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnboundedFollowingWindowBenchmark.scala: ########## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.benchmark + +import org.apache.spark.benchmark.Benchmark +import org.apache.spark.sql.internal.SQLConf + +/** + * Benchmark for shrinking ROWS frames (... BETWEEN <lower> AND UNBOUNDED FOLLOWING). + * + * Today's `UnboundedFollowingWindowFunctionFrame` runs the suffix aggregate + * O(n * (n - 1) / 2) per partition (acknowledged inline at + * `WindowFunctionFrame.scala:636`). The segtree path replaces this with + * O(n log n) when `spark.sql.window.segmentTree.enabled=true`. + * + * Layout: single partition on a non-partitioned ORDER BY (the worst case; + * with PARTITION BY the cost decomposes as sum-of-partition N^2 and is + * dominated by the largest partition). + * + * Sections: + * - A: per-aggregate equivalence at N=10K (naive ~3-5s/iter target). + * - B: N-sweep for SUM, naive vs segtree, demonstrating the algorithmic + * gap. N=50K is the largest naive run (~60s/iter); N=100K and 200K + * are segtree-only because naive would take ~4-16 min/iter. + */ +object UnboundedFollowingWindowBenchmark extends SqlBasedBenchmark { + + // Section A: calibrated so naive baseline lands ~3s/iter at MAIN_N. Review Comment: `MAIN_N` doesn't exist — the constant is `A_N`: ```suggestion // Section A: calibrated so naive baseline lands ~3s/iter at A_N. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
