gaogaotiantian commented on code in PR #56461:
URL: https://github.com/apache/spark/pull/56461#discussion_r3405978250
##########
.github/workflows/build_non_ansi.yml:
##########
@@ -33,17 +31,17 @@ jobs:
if: github.repository == 'apache/spark'
with:
java: 17
- branch: master
hadoop: hadoop3
envs: >-
{
"PYSPARK_IMAGE_TO_TEST": "python-311",
"PYTHON_TO_TEST": "python3.11",
- "SPARK_ANSI_SQL_MODE": "false",
Review Comment:
I believe the trailing comma is actually wrong. This is a JSON string and
JSON does not allow trailing comma. `fromJSON` would crash with it. It was not
caught because this file was not ever used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
