cloud-fan commented on code in PR #56480: URL: https://github.com/apache/spark/pull/56480#discussion_r3406719632
########## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/JSONArchiveReadBase.scala: ########## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.datasources + +import java.io.File +import java.nio.charset.StandardCharsets +import java.nio.file.Files + +import org.apache.spark.sql.{AnalysisException, DataFrame} +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.sql.types.{NullType, StringType} +import org.apache.spark.util.Utils + +/** + * Binds [[ArchiveReadSuiteBase]]'s file-format hooks to JSON. JSON opts into the shared + * schema-inference and complex-type tests (see `supportsSchemaInference`/`supportsComplexTypes`), + * and adds the JSON-specific tests with no format-agnostic analogue: NullType canonicalization, + * field-union/null-in-loose merging, and multi-line documents. Reusable across archive formats: a + * `JSON<Archive>Read` suite mixes this in alongside the archive-format trait. Review Comment: `JSON<Archive>Read` doesn't expand to the real suite name — the tar suite is `JSONTarArchiveReadSuite`, and `TarArchiveReadBase` documents the `<format>TarArchiveReadSuite` pattern. ```suggestion * `JSON<Container>ArchiveReadSuite` mixes this in alongside the archive-format trait. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
