dwsmith1983 commented on PR #56071: URL: https://github.com/apache/spark/pull/56071#issuecomment-4700642339
Hi @sunchao and @MaxGekk , thanks for getting this merged. A note on attribution. The core move in this PR, making hasSelectivePredicate return true for an already-materialized leaf that has no Filter, was first introduced in #53263 (SPARK-54554) on Nov 29, 2025 (CommandResult), and extended to LocalRelation and LogicalRDD in #53324 (SPARK-54593). This PR references #53324 but not #53263, which is the earlier PR where the mechanism and the materialized-input rationale originated. Two small asks. First, could #53263 / SPARK-54554 be referenced alongside #53324 so the lineage is on the record? Second, given the merged work generalizes the approach from those PRs, would a co-author acknowledgment for #53263 (co-authored with @mc8max and @dwsmith1983) be appropriate, whether on the Jira or in a follow-up note? I understand the commit itself is already in history; even a reference on the ticket would be great. Thanks for considering it. Prior PRs: - https://github.com/apache/spark/pull/53263 - https://github.com/apache/spark/pull/53324 Jira: - https://issues.apache.org/jira/browse/SPARK-54554 - https://issues.apache.org/jira/browse/SPARK-54593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
