uros-b commented on code in PR #56375: URL: https://github.com/apache/spark/pull/56375#discussion_r3409163186
########## sql/core/src/test/resources/sql-tests/inputs/timestamp-ntz-nanos.sql: ########## @@ -65,3 +65,21 @@ SELECT extract(SECOND FROM NULL :: timestamp_ntz(9)); -- Pre-epoch nanosecond values exercise the negative-epoch path. SELECT extract(SECOND FROM TIMESTAMP_NTZ '1960-01-01 13:24:35.123456789'); + +-- DATE <-> TIMESTAMP_NTZ(p) casts (SPARK-57323): midnight UTC / date extraction (zone-independent). Review Comment: The golden-file inputs only test LTZ -> DATE with 12:30:15.123456789 (drop time-of-day) and the pre-epoch .000000001 case. Consider one input where the session time zone actually changes the resulting date for LTZ (e.g. a near-midnight instant), so the .sql golden files demonstrate zone-dependence, not just the Scala suite. Not blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
