deepujain commented on code in PR #54695:
URL: https://github.com/apache/spark/pull/54695#discussion_r3409879190
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -305,10 +305,8 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase with ExecutionE
def ansiDateTimeArgumentOutOfRange(e: Exception): SparkDateTimeException = {
new SparkDateTimeException(
- errorClass = "DATETIME_FIELD_OUT_OF_BOUNDS.WITH_SUGGESTION",
- messageParameters = Map(
- "rangeMessage" -> e.getMessage,
- "ansiConfig" -> toSQLConf(SQLConf.ANSI_ENABLED.key)),
+ errorClass = "DATETIME_FIELD_OUT_OF_BOUNDS.WITHOUT_SUGGESTION",
Review Comment:
Addressed this by widening `ansiDateTimeArgumentOutOfRange` to `Throwable`,
deleting `ansiDateTimeArgumentOutOfRangeWithoutSuggestion`, and switching the
three `DateTimeUtils` call sites over. Rebased on current master and reran
`./build/sbt "sql/testOnly
org.apache.spark.sql.errors.QueryExecutionAnsiErrorsSuite -- -z SPARK-49642"`
plus `./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z
time.sql"` - both passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
