cloud-fan commented on code in PR #56465:
URL: https://github.com/apache/spark/pull/56465#discussion_r3409933647
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -3877,6 +3879,45 @@ class DataSourceV2SQLSuiteV1Filter
}
}
+ test("CREATE TABLE with DEFAULT COLLATION applies the collation to the " +
+ "ResolvedIdentifier output columns") {
Review Comment:
Non-blocking: the sibling collation tests this PR adds live in
`CollationSuite`, which also extends `DatasourceV2SQLBase` (so `testcat` is
available there). Consider co-locating this one with them for discoverability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
