shrirangmhalgi commented on PR #56126:
URL: https://github.com/apache/spark/pull/56126#issuecomment-4705011471
Thanks @yadavay-amzn and @cloud-fan for the reviews! Addressed all points in
the latest commit:
- Wrapped post-setupJob in `try { ... } catch { committer.abortJob(job);
throw }` so staging dirs are cleaned up if `materializeAdaptiveSparkPlan` throws
- Replaced string literal with `SQLConf.PLANNED_WRITE_ENABLED.key`
- Added comment explaining why a leaked staging dir is acceptable
(dot/underscore-prefixed, filtered from reads, self-heals on next overwrite)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
