Richard-Durkee commented on code in PR #56130:
URL: https://github.com/apache/spark/pull/56130#discussion_r3415705854
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala:
##########
@@ -662,8 +666,9 @@ private[sql] object UnivocityParser {
val filteredLines: Iterator[String] =
CSVExprUtils.filterCommentAndEmpty(lines, options)
+ val lineSep = options.lineSeparator.getOrElse("\n")
Review Comment:
Hi @MaxGekk, thank you for the review and for your patience with my
responsiveness this last week. Yes, I believe my implementation handles this
case, and I have since added a test to cover this case.
This is my first Spark PR, so please let me know if there is anything else
you'd like to see in it.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala:
##########
@@ -662,8 +666,9 @@ private[sql] object UnivocityParser {
val filteredLines: Iterator[String] =
CSVExprUtils.filterCommentAndEmpty(lines, options)
+ val lineSep = options.lineSeparator.getOrElse("\n")
Review Comment:
Hi @MaxGekk, thank you for the review and for your patience with my
responsiveness this last week. Yes, I believe my implementation handles this
case, and I have since added a test to cover customer line separators.
This is my first Spark PR, so please let me know if there is anything else
you'd like to see in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
