LuciferYang commented on code in PR #56534: URL: https://github.com/apache/spark/pull/56534#discussion_r3417868703
########## connector/db2-jcc-shaded/pom.xml: ########## @@ -0,0 +1,84 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.spark</groupId> + <artifactId>spark-parent_2.13</artifactId> + <version>5.0.0-SNAPSHOT</version> + <relativePath>../../pom.xml</relativePath> + </parent> + + <artifactId>spark-db2-jcc-shaded_2.13</artifactId> + <packaging>jar</packaging> + <name>Spark Project Shaded DB2 JCC Driver (test-only)</name> + <url>https://spark.apache.org/</url> + <properties> + <sbt.project.name>db2-jcc-shaded</sbt.project.name> + <!-- + The DB2 JDBC driver (com.ibm.db2:jcc) bundles its own copy of lz4-java + under the unshaded net.jpountz.* packages. That collides with the + net.jpountz.lz4 that Spark itself ships and breaks + LZ4BlockInputStream.newBuilder() on any test classpath that also pulls the + driver (SPARK-55706 disabled the DB2 tests to avoid this). This module + repackages the driver with net.jpountz relocated so the two copies can + coexist, letting the DB2 tests be re-enabled (SPARK-55707). + + This is a test-only repackaging of a third-party driver; never publish it. + --> + <maven.deploy.skip>true</maven.deploy.skip> + </properties> + + <dependencies> + <dependency> + <groupId>com.ibm.db2</groupId> + <artifactId>jcc</artifactId> + <!-- compile scope (overriding the test-scoped dependencyManagement entry) + so the driver classes are bundled into the shaded artifact. --> + <scope>compile</scope> + </dependency> + </dependencies> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <configuration> Review Comment: seems we should adding `combine.self="override"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
