MaxGekk commented on PR #56519: URL: https://github.com/apache/spark/pull/56519#issuecomment-4718226990
I pushed two follow-up commits that only enable existing test coverage now unblocked by this change; the runtime behavior of the PR is unchanged: - Enable the `timestamp-ntz-nanos.sql` and `timestamp-ltz-nanos.sql` golden-file tests in `ThriftServerQueryTestSuite` (they were ignored only because nanos types were not yet mapped by the Thrift server). - Drop the `cast(... as string)` workaround for the micros -> nanos widening cases in `cast.sql`, so they produce bare `TIMESTAMP_NTZ(9)` / `TIMESTAMP_LTZ(9)` columns. Golden files were regenerated and the output values are unchanged (only the result column type changes from `string` to the nanos type). No production code changed beyond the original `thriftTypeName` override. The PR description is updated accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
