uros-b commented on code in PR #56540:
URL: https://github.com/apache/spark/pull/56540#discussion_r3420833723
##########
sql/api/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala:
##########
@@ -160,11 +160,18 @@ private[sql] object AnyTimestampType extends
AbstractDataType with Serializable
override private[sql] def simpleString = "(timestamp or timestamp without
time zone)"
}
+/**
+ * A nanosecond-precision timestamp type (`TIMESTAMP_LTZ(p)` /
`TIMESTAMP_NTZ(p)`, `p` in [7, 9]).
+ */
+private[sql] abstract class AnyTimestampNanoType extends DatetimeType {
+ def precision: Int
Review Comment:
Is this currently used at all?
None of the converted call sites read .precision polymorphically, and the
sibling abstraction AnyTimeType deliberately does not expose precision (even
though TimeType has it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
