yadavay-amzn commented on PR #56472: URL: https://github.com/apache/spark/pull/56472#issuecomment-4722148404
Thanks @szehon-ho for the feedback. Addressed all comments (replies are inline). On `INVALID_TEMP_OBJ_REFERENCE`, I kept it to match the existing persistent-view precedent for the same "persistent object references a temporary object" category and to avoid growing the error-class surface. You're right that the shared template's "...or make the persistent object temporary" remediation doesn't map cleanly to a constraint so if you'd prefer a dedicated *_CHECK_CONSTRAINT error class instead, I'm happy to switch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
