uros-b commented on code in PR #56533:
URL: https://github.com/apache/spark/pull/56533#discussion_r3430293794
##########
python/pyspark/pandas/tests/series/test_string_ops_adv.py:
##########
@@ -86,6 +86,17 @@ def test_string_findall(self):
lambda x: x.str.findall("wh.*", flags=re.IGNORECASE),
self.pser, ignore_null=True
)
+ pser = pd.Series(["abc-123 def-456", "no match"])
Review Comment:
This test doesn't cover the null + multi-group path. It only exercises list
rows; "no match" returns [], not NaN. The isinstance guard's NaN branch is
therefore untested. Please consider adding a None element to the series to lock
in that behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
