vjanelle commented on code in PR #43503: URL: https://github.com/apache/spark/pull/43503#discussion_r3430320383
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/StaxXmlGenerator.scala: ########## @@ -16,164 +16,201 @@ */ package org.apache.spark.sql.catalyst.xml +import java.io.Writer import java.sql.Timestamp -import javax.xml.stream.XMLStreamWriter +import javax.xml.stream.XMLOutputFactory import scala.collection.Map +import com.sun.xml.txw2.output.IndentingXMLStreamWriter +import org.apache.hadoop.shaded.com.ctc.wstx.api.WstxOutputProperties Review Comment: @sandip-db @HyukjinKwon is importing the shaded version intentional? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
