akshatshenoi-db commented on code in PR #56572:
URL: https://github.com/apache/spark/pull/56572#discussion_r3432209275
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/xml/XmlFileFormat.scala:
##########
@@ -116,14 +120,25 @@ case class XmlFileFormat() extends TextBasedFileFormat
with DataSourceRegister {
}
(file: PartitionedFile) => {
- val parser = new StaxXmlParser(
+ def parser() = new StaxXmlParser(
Review Comment:
per entry factory is intended to keep parity with the non archive read path
if parser construction ever becomes file/entry-dependent the archive path stays
correct without need for revisit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
