dongjoon-hyun commented on code in PR #56505:
URL: https://github.com/apache/spark/pull/56505#discussion_r3433025994
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -6329,6 +6329,19 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val PUSH_VARIANT_INTO_SCAN_DEFER_CAST_ERROR =
+ buildConf("spark.sql.variant.pushVariantIntoScan.deferCastError")
+ .internal()
+ .doc("When true, strict variant casts that get pushed into the scan are
wrapped with a " +
+ "per-row cast-error companion column (nullable string) so that the
cast error is only " +
+ "raised when the row is consumed by the user expression. Without this
flag, the cast is " +
+ "always evaluated and any failure raises immediately, even when the
surrounding " +
+ "expression would not have consumed the failing row.")
+ .version("4.3.0")
Review Comment:
BTW, this PR code itself seems to have a wrong version, @cloud-fan .
I'd like to recommend to fix `master` and `branch-4.x` first before making a
backport to `branch-4.2`, @chenhao-db .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
