uros-b commented on code in PR #56577:
URL: https://github.com/apache/spark/pull/56577#discussion_r3436173671
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -1969,9 +2027,24 @@ case class Cast(
case TimestampNTZType =>
(c, evPrim, evNull) =>
code"$evPrim = TimestampNanosVal.fromParts($c, (short) 0);"
+ case TimestampType =>
+ val zoneIdClass = classOf[ZoneId]
+ val zid = JavaCode.global(
+ ctx.addReferenceObj("zoneId", zoneId, zoneIdClass.getName),
+ zoneIdClass)
+ (c, evPrim, evNull) =>
+ code"$evPrim = TimestampNanosVal.fromParts(" +
+ code"$dateTimeUtilsCls.convertTz($c, java.time.ZoneOffset.UTC,
$zid), (short) 0);"
case _: TimestampNTZNanosType =>
(c, evPrim, evNull) =>
code"$evPrim = $dateTimeUtilsCls.truncateTimestampNanosToPrecision($c,
$precision);"
+ case _: TimestampLTZNanosType =>
+ val zoneIdClass = classOf[ZoneId]
+ val zid = JavaCode.global(
+ ctx.addReferenceObj("zoneId", zoneId, zoneIdClass.getName),
+ zoneIdClass)
+ (c, evPrim, evNull) =>
+ code"$evPrim = $dateTimeUtilsCls.timestampLTZNanosToNTZNanos($c, $zid,
$precision);"
Review Comment:
There's a lot of code duplication in codegen parts. Each new codegen arm
registers its own zoneId reference object. Could we reduce the duplication and
hoist the zid once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
