sunchao commented on PR #56293: URL: https://github.com/apache/spark/pull/56293#issuecomment-4743504989
@cloud-fan Good catch, you're right. I missed marking the second minimum-drop branch. Fixed in `d08d28d`: it now sets the same marker, and `bytesToBytesMapFallsBackFromExactFitPageAfterSpill` reproduces the spill-active sequence `[1024, 4096, 4096, 36]` and verifies that `BytesToBytesMap` falls back rather than retaining the exact-fit page. `TaskMemoryManagerSuite` and both on-heap and off-heap `BytesToBytesMap` suites pass. The external sorters are different: after accepting an exact-fit page, the next failed full-page allocation makes each sorter self-spill and free its data pages, so they cannot accumulate one page-table slot per record like `BytesToBytesMap`. The guard is therefore intentionally limited to the consumers that cannot safely retain these pages. I also updated the PR description to document the marker and consumer fallback behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
