sarutak commented on code in PR #56605:
URL: https://github.com/apache/spark/pull/56605#discussion_r3439622762
##########
bin/docker-image-tool.sh:
##########
@@ -261,18 +261,18 @@ Examples:
$0 -m -t testing build
- Build PySpark docker image
- $0 -r docker.io/myrepo -t v4.0.0 -p
kubernetes/dockerfiles/spark/bindings/python/Dockerfile build
+ $0 -r docker.io/myrepo -t v5.0.0 -p
kubernetes/dockerfiles/spark/bindings/python/Dockerfile build
- - Build and push image with tag "v4.0.0" to docker.io/myrepo
- $0 -r docker.io/myrepo -t v4.0.0 build
- $0 -r docker.io/myrepo -t v4.0.0 push
+ - Build and push image with tag "v5.0.0" to docker.io/myrepo
+ $0 -r docker.io/myrepo -t v5.0.0 build
+ $0 -r docker.io/myrepo -t v5.0.0 push
- - Build and push Java17-based image with tag "v4.0.0" to docker.io/myrepo
- $0 -r docker.io/myrepo -t v4.0.0 -b java_image_tag=17 build
- $0 -r docker.io/myrepo -t v4.0.0 push
+ - Build and push Java17-based image with tag "v5.0.0" to docker.io/myrepo
Review Comment:
nit: The description says "Java17-based" but the example uses
java_image_tag=21. Should the description be updated to "Java21-based"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
