iemejia commented on code in PR #56479:
URL: https://github.com/apache/spark/pull/56479#discussion_r3447000843
##########
.github/workflows/benchmark.yml:
##########
@@ -73,7 +78,11 @@ jobs:
# Any TPC-DS related updates on this job need to be applied to tpcds-1g job
of build_and_test.yml as well
tpcds-1g-gen:
name: "Generate an TPC-DS dataset with SF=1"
- if: contains(inputs.class, 'TPCDSQueryBenchmark') ||
contains(inputs.class, 'LZ4TPCDSDataBenchmark') || contains(inputs.class,
'ZStandardTPCDSDataBenchmark') || contains(inputs.class, '*')
+ # Only generate TPC-DS data when running TPC-DS benchmarks or all
benchmarks (class == '*').
+ # Use contains(inputs.class, 'TPCDS') to catch both exact class names and
globs like '*TPCDS*'.
+ # Use exact equality for '*' to avoid matching wildcard patterns like
+ # '*VectorizedDeltaReaderBenchmark' that don't need TPC-DS data.
+ if: contains(inputs.class, 'TPCDS') || inputs.class == '*'
Review Comment:
Done -- replaced the auto-detection with an explicit `generate-tpcds`
boolean input (default: `true`). The `if:` condition now simply checks
`inputs.generate-tpcds`, so there are no heuristics or edge cases to worry
about. Users running non-TPC-DS benchmarks can set it to `false` to skip the
~10 min generation step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
