uros-b commented on code in PR #56422:
URL: https://github.com/apache/spark/pull/56422#discussion_r3447582171
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/types/ops/TimeTypeParquetOps.scala:
##########
@@ -106,7 +106,8 @@ private[ops] object TimeTypeParquetOps {
parquetType.asPrimitiveType.getPrimitiveTypeName == INT64 &&
(parquetType.getLogicalTypeAnnotation match {
case t: LogicalTypeAnnotation.TimeLogicalTypeAnnotation =>
- t.getUnit == TimeUnit.MICROS && !t.isAdjustedToUTC
+ t.getUnit == TimeUnit.MICROS &&
+ (!t.isAdjustedToUTC || SQLConf.get.parquetTimeIsAdjustedToUTC)
Review Comment:
Noting fragility here - TimeTypeParquetOps.requireCompatibleParquetType
reads SQLConf.get instead of the plumbed flag. Everywhere else the PR goes out
of its way to thread the flag explicitly. Let's plumb the flag through the same
channel the converter uses, rather than SQLConf.get.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
