uros-b commented on code in PR #56638:
URL: https://github.com/apache/spark/pull/56638#discussion_r3448563350
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionHelper.scala:
##########
@@ -244,14 +247,54 @@ abstract class TypeCoercionHelper {
(d1, d2) match {
case (_, _: TimeType) => None
case (_: TimeType, _) => None
Review Comment:
Nit: Should we future-proof the TimeType guards here? The arms match _:
TimeType specifically rather than _: AnyTimeType. If another AnyTimeType
subtype is ever added, it would fall through to case _ and hit the
internalError (acceptable fail-fast), but matching _: AnyTimeType there would
be marginally more intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
