stevomitric opened a new pull request, #56656: URL: https://github.com/apache/spark/pull/56656
### What changes were proposed in this pull request? Phase 3a ([SPARK-55444](https://issues.apache.org/jira/browse/SPARK-55444)) routes `TimeType` through the Types Framework first (`ParquetTypeOps(dt).map(...).getOrElse(...Default)`), so the `case _: TimeType` arms left in the `*Default` fallbacks are unreachable. This removes them from `ParquetSchemaConverter.convertFieldDefault`, `ParquetWriteSupport.makeWriterDefault`, and `ParquetRowConverter.newConverterDefault` . ### Why are the changes needed? Dead code: each `*Default` method has a single caller (the framework `getOrElse`), and `ParquetTypeOps` always handles `TimeType`, so those arms never run. Mirrors SPARK-57372's follow-up (`f3d1de5ced5`), which removed the analogous dead `TimeType` paths in catalyst/api/connect/hive but did not touch these Parquet ones. ### Does this PR introduce _any_ user-facing change? No. Pure dead-code removal; `TimeType` is handled by the framework path. ### How was this patch tested? Existing suites, no behavior change: `TimeTypeParquetOpsSuite` + `ParquetSchemaSuite` (145 tests) and `ParquetIOSuite` TimeType reads (2 tests). ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
