HyukjinKwon opened a new pull request, #56658:
URL: https://github.com/apache/spark/pull/56658

   ### What changes were proposed in this pull request?
   
   Upgrade `log4j` from 2.25.x to **2.26.0** (`pom.xml` and the 
`dev/deps/spark-deps-*`
   dependency manifests).
   
   ### Why are the changes needed?
   
   Under JDK 25, log4j2's `ThrowableStackTraceRenderer` throws
   `NullPointerException: Cannot read field "stackLength" because "metadata" is 
null` while
   rendering an exception's stack trace. This breaks rendering of *any* logged 
exception on
   JDK 25 and surfaces as `FsHistoryProviderSuite` "provider reports error 
after FS leaves safe
   mode" failing on the JDK 25 scheduled builds. Example failing upstream run 
(Build / Java25):
   https://github.com/apache/spark/actions/runs/27894816608
   
   log4j 2.26.0 fixes this (snapshots the stack trace during metadata 
population, upstream
   LOG4J2 #3940 / #3955).
   
   ### Does this PR introduce any user-facing change?
   
   No. Build/logging dependency upgrade.
   
   ### How was this patch tested?
   
   Validated on fork CI.
   - `FsHistoryProviderSuite` "provider reports error after FS leaves safe 
mode" is GREEN on
     **JDK 25** with this bump: 
https://github.com/HyukjinKwon/spark/actions/runs/27929988232
   - Fully GREEN combined Maven (Scala 2.13, JDK 21) run that includes this 
log4j bump, 0 failed
     jobs: **https://github.com/HyukjinKwon/spark/actions/runs/27935083986**
   
   Note: the full `Build / Java25` build is still blocked by a SEPARATE JDK 
25-preview issue
   (`DateExpressionsSuite` "TruncTimestamp of Long.MinValue overflows ..." 
codegen behavior),
   tracked separately. This PR resolves the log4j NPE specifically. The last 
commit only flips a
   workflow guard for fork validation and is marked [DO NOT MERGE].
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Yes. Drafted with Claude Code (Anthropic) and reviewed before submission.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to