uros-b commented on code in PR #56652:
URL: https://github.com/apache/spark/pull/56652#discussion_r3452231736
##########
python/pyspark/pipelines/tests/test_add_pipeline_analysis_context.py:
##########
@@ -89,6 +90,25 @@ def test_nested_add_pipeline_analysis_context(self):
thread_local_extensions_after_2 =
self.spark.client.thread_local.user_context_extensions
self.assertEqual(len(thread_local_extensions_after_2), 0)
+ def test_setup_failure_does_not_mask_original_error(self):
Review Comment:
Nit: the new test exercises only the
`add_threadlocal_user_context_extension` failure path; whereas the PR
description also names the proto import and Pack/construction as failure
points. Can we add a few more tests accordingly? (not blocking)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
