davidm-db commented on PR #56661: URL: https://github.com/apache/spark/pull/56661#issuecomment-4769620984
> cc @davidm-db - this is one of the followups for vectorized read. What do you think about the change? The issue that caught my eye was `getUpdater` has shared vectorized readers for specific types - so we would have to move the logic to parquet ops. personally, I'm fine with the change as-is, for a few reasons: - if we were writing this from zero, we would do what your PR does - we don't have any new types in the plan at the moment that would hit this issue - at some points, we need to pay for not fully rewriting all types through the framework - this seems like a small cost - we can always figure out some kind of a solution when needed let's see if anyone else has any thoughts.. @MaxGekk do you have an opinion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
