szehon-ho opened a new pull request, #56680:
URL: https://github.com/apache/spark/pull/56680

   ### What changes were proposed in this pull request?
   
   This PR improves the left-navigation experience for the Data Source V2 
documentation page in the SQL guide:
   
   - Renames the page `docs/sql-data-sources-v2.md` 
(`sql-data-sources-v2.html`) to `docs/sql-v2-data-sources.md` 
(`sql-v2-data-sources.html`). The page content is unchanged (pure rename).
   - Adds per-section sub-items for the page to the SQL guide sidebar 
(`docs/_data/menu-sql.yaml`): Overview, Entry Points, Catalog Interfaces, 
Table, View, Read Path, Write Path, Row-Level DML, Expressions, Streaming, and 
Further Reading.
   - Updates the internal link in `docs/sql-ref-syntax-dml-merge-into.md` to 
point at the new URL.
   
   ### Why are the changes needed?
   
   In the SQL guide sidebar, selecting **Data Source V2** incorrectly expanded 
the sibling **Data Sources** group instead of the Data Source V2 entry, and the 
page exposed no section links in the sidebar.
   
   The sidebar template (`docs/_includes/nav-left.html`) decides which group to 
expand by checking whether the current page URL contains a group's URL with 
`.html` stripped (i.e. a substring/prefix match). Because the page URL leaf 
`sql-data-sources-v2` contains the `sql-data-sources` prefix of the **Data 
Sources** group, that group was matched and expanded.
   
   Renaming the page to `sql-v2-data-sources` removes the prefix overlap so the 
correct entry is selected, and the new sub-items make the page's sections 
navigable from the sidebar (consistent with other entries such as Performance 
Tuning).
   
   ### Does this PR introduce _any_ user-facing change?
   
   No (documentation-only). Note that the Data Source V2 page URL changes from 
`sql-data-sources-v2.html` to `sql-v2-data-sources.html`; no redirect is added 
for the old URL.
   
   ### How was this patch tested?
   
   Built the docs site locally (`SKIP_API=1 bundle exec jekyll build`) and 
verified in the rendered sidebar that:
   - selecting **Data Source V2** expands its own section links,
   - the **Data Sources** group is no longer expanded on the Data Source V2 
page,
   - other pages (e.g. Parquet Files, SQL Reference subpages) still expand 
their groups as before.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Cursor


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to