holdenk commented on code in PR #56679: URL: https://github.com/apache/spark/pull/56679#discussion_r3456381703
########## .github/workflows/build_python_3.9.yml: ########## @@ -0,0 +1,44 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build / Python-only" + +on: + workflow_dispatch: + +jobs: + run-build: + permissions: + packages: write Review Comment: Do we need this? We don't write any packages as part of the workflow or do we? ########## .github/workflows/build_python_3.9.yml: ########## @@ -0,0 +1,44 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build / Python-only" + +on: + workflow_dispatch: + +jobs: + run-build: + permissions: + packages: write + name: Run + uses: ./.github/workflows/build_and_test.yml + if: github.repository == 'apache/spark' + with: + java: 8 + hadoop: hadoop3 + envs: >- + { + "PYSPARK_IMAGE_TO_TEST": "", Review Comment: What's this env variable for? I don't see any refs to it in the latest version 03733f171795a9da8fcadf4915d323f442129118 and we don't seem to use it in the newly added code. ########## .github/workflows/build_scala213.yml: ########## @@ -32,18 +31,20 @@ jobs: if: github.repository == 'apache/spark' with: java: 8 - branch: master hadoop: hadoop3 envs: >- { - "SCALA_PROFILE": "scala2.13" + "SCALA_PROFILE": "scala2.13", + "PYSPARK_IMAGE_TO_TEST": "", + "PYTHON_TO_TEST": "", + "ORACLE_DOCKER_IMAGE_NAME": "gvenzl/oracle-xe:21.3.0" } jobs: >- { "build": "true", - "pyspark": "true", "sparkr": "true", "tpcds-1g": "true", "docker-integration-tests": "true", + "k8s-integration-tests": "true", Review Comment: Given the goal is to reduce usage/timeouts lets drop this no need to repeat this in Scala 2.13 as well as the 2.12 run right? ########## .github/workflows/build_scala213.yml: ########## @@ -32,18 +31,20 @@ jobs: if: github.repository == 'apache/spark' with: java: 8 - branch: master hadoop: hadoop3 envs: >- { - "SCALA_PROFILE": "scala2.13" + "SCALA_PROFILE": "scala2.13", + "PYSPARK_IMAGE_TO_TEST": "", + "PYTHON_TO_TEST": "", + "ORACLE_DOCKER_IMAGE_NAME": "gvenzl/oracle-xe:21.3.0" Review Comment: Is this using JDK21? I don't think that make sense with the Java8 up above? That being said it seems like we're already using it so maybe if this just used for the JRE that's fine. ########## .github/workflows/build_python_3.9.yml: ########## @@ -0,0 +1,44 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build / Python-only" + +on: + workflow_dispatch: + +jobs: + run-build: + permissions: + packages: write + name: Run + uses: ./.github/workflows/build_and_test.yml + if: github.repository == 'apache/spark' + with: + java: 8 + hadoop: hadoop3 + envs: >- Review Comment: Where do we set the Python version to 3.9? ########## .github/workflows/build_python_3.9.yml: ########## @@ -0,0 +1,44 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Build / Python-only" + +on: + workflow_dispatch: + +jobs: + run-build: + permissions: + packages: write + name: Run + uses: ./.github/workflows/build_and_test.yml + if: github.repository == 'apache/spark' + with: + java: 8 + hadoop: hadoop3 + envs: >- + { + "PYSPARK_IMAGE_TO_TEST": "", + "PYTHON_TO_TEST": "" Review Comment: Again this variable does not seem used ########## .github/workflows/build_scala213.yml: ########## @@ -32,18 +31,20 @@ jobs: if: github.repository == 'apache/spark' with: java: 8 - branch: master hadoop: hadoop3 envs: >- { - "SCALA_PROFILE": "scala2.13" + "SCALA_PROFILE": "scala2.13", + "PYSPARK_IMAGE_TO_TEST": "", + "PYTHON_TO_TEST": "", Review Comment: What are these for/where are they used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
