LuciferYang commented on PR #56648:
URL: https://github.com/apache/spark/pull/56648#issuecomment-4779137604
Thanks @MaxGekk! Addressed both points in `33fc38af962`:
1. Reworded the test comment to describe what the test actually verifies
(the scan continues past the default-value replacement and still expands the
later `${b}`), rather than implying the length adjustment is required — you're
right that it passes either way, so the old wording was misleading.
2. Updated the PR description to document the second production change
(`value.toString` -> `String.valueOf(value)`, so a null resolver value renders
as `"null"` instead of NPEing) and noted why it isn't user-facing: the sole
caller, `ErrorClassesJSONReader`, already maps null message parameters to
`"null"` before constructing the substitutor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
