MaxGekk commented on code in PR #56677:
URL: https://github.com/apache/spark/pull/56677#discussion_r3460527528
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -986,6 +986,23 @@ class SparkConnectProtoSuite extends PlanTest with
SparkConnectPlanTest {
sparkTestRelation.select(col("id").cast("string")))
}
+ test("SPARK-57618: cast TIMESTAMP_NTZ to TIME") {
Review Comment:
The reverse direction isn't exercisable over Connect yet: TIME ->
TIMESTAMP_NTZ requires the source column to be a TIME column, but the Connect
DataType proto converter doesn't support TIME yet (the TIMESTAMP_NTZ -> TIME
test works only because the target TIME is carried as a parsed type string, not
in the schema proto). The cast logic itself is fully covered in both directions
by the Catalyst CastSuite* suites; this Connect test just confirms the pair
round-trips through the planner. I've noted this in the test comment - happy to
add the reverse case once TIME lands in the proto converter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
