vranes commented on code in PR #56674:
URL: https://github.com/apache/spark/pull/56674#discussion_r3461208680
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -411,13 +417,13 @@
"message" : [
"The range columns in BIN BY must be TIMESTAMP or TIMESTAMP_NTZ. Column
<columnName> has type <columnType>. Both range columns must have the same type."
],
- "sqlState" : "42804"
+ "sqlState" : "42K09"
},
"BIN_BY_REQUIRES_TOP_LEVEL_COLUMN" : {
"message" : [
"BIN BY requires a top-level column, but <columnName> is a nested or
computed field. Alias it to a top-level column in a select before BIN BY."
],
- "sqlState" : "42K09"
+ "sqlState" : "0A000"
Review Comment:
I originally put 42K09 because of EVENT_TIME_MUST_BE_TOP_LEVEL_COLUMN
precedent but later I got feedback from Serge that it should be 0A000, and IMO
we should prioritize accuracy over consistency in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
