uros-b commented on code in PR #56621:
URL: https://github.com/apache/spark/pull/56621#discussion_r3461252943
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/BasicStatsEstimationSuite.scala:
##########
@@ -193,6 +193,30 @@ test("range with invalid long value") {
checkStats(range, rangeStats, rangeStats)
}
+ test("SPARK-52163: cap estimated size in bytes to avoid BigInt overflow") {
+ val hugeAttr = attr("id")
+ // A leaf node whose estimated size is already at the maximum
representable physical size.
+ val hugePlan = StatsTestPlan(
Review Comment:
The unit test with StatsTestPlan is adequate for a simple regression test.
However, a small end-to-end test mirroring the JIRA snippet (empty DataFrame +
self-join loop + checkpoint + explain("cost")) would lock in the
LogicalRDD/originStats propagation path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
