Github user rtreffer commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6796#discussion_r32371677
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRDD.scala 
---
    @@ -331,7 +331,7 @@ private[sql] class JDBCRDD(
           case BooleanType => BooleanConversion
           case DateType => DateConversion
           case DecimalType.Unlimited => DecimalConversion(None)
    -      case DecimalType.Fixed(d) => DecimalConversion(Some(d))
    +      case DecimalType.Fixed(d, s) => DecimalConversion(Some((d, s)))
    --- End diff --
    
    It caused a warning on my system. So I thought it would be better to make 
it explicit.
    
    I could drop that line from this patch, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to