sarutak commented on PR #56669: URL: https://github.com/apache/spark/pull/56669#issuecomment-4781308289
@dongjoon-hyun When you suggested adding `spark.ui.contentSecurityPolicy.frameAncestors.enabled`, I interpreted "fallback for this transition" as: since the full CSP is too strong right now, this sub-config allows emitting just `frame-ancestors` without the full CSP so that `allowFramingFrom` works during the transition to full CSP. If your intent is that no CSP header should be emitted at all when `contentSecurityPolicy.enabled=false`, I can make that change. However, I'd like to point out that these two goals are mutually exclusive: - **Design consistency**: CSP disabled = no CSP header at all - **`allowFramingFrom` working as intended**: requires `frame-ancestors`, which can only exist in a CSP header There is no browser mechanism to allow framing from a specific origin without a CSP header. If we choose design consistency, `allowFramingFrom` becomes non-functional unless users explicitly enable CSP. Since `ALLOW-FROM` was already broken in browsers, this doesn't cause a regression in practice, but it does mean the originally intended behavior of `allowFramingFrom` cannot work by default. Which trade-off do you prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
