dongjoon-hyun commented on code in PR #56685:
URL: https://github.com/apache/spark/pull/56685#discussion_r3461605491
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/json/JsonExpressionEvalUtils.scala:
##########
@@ -726,3 +791,45 @@ case class MultiGetJsonObjectEvaluator(
if (renderingFailed) None else
Some(UTF8String.fromBytes(outputBuffer.toByteArray))
}
}
+
+object MultiGetJsonObjectEvaluator {
+ private final class MutablePathTrieNode {
+ val terminalOrdinals: scala.collection.mutable.ArrayBuffer[Int] =
+ scala.collection.mutable.ArrayBuffer.empty
+ val children: scala.collection.mutable.LinkedHashMap[String,
MutablePathTrieNode] =
+ scala.collection.mutable.LinkedHashMap.empty
Review Comment:
Shall we import `scala.collection.mutable` because we use at least 4 times
here?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/json/JsonExpressionEvalUtils.scala:
##########
@@ -726,3 +791,45 @@ case class MultiGetJsonObjectEvaluator(
if (renderingFailed) None else
Some(UTF8String.fromBytes(outputBuffer.toByteArray))
}
}
+
+object MultiGetJsonObjectEvaluator {
+ private final class MutablePathTrieNode {
+ val terminalOrdinals: scala.collection.mutable.ArrayBuffer[Int] =
+ scala.collection.mutable.ArrayBuffer.empty
+ val children: scala.collection.mutable.LinkedHashMap[String,
MutablePathTrieNode] =
+ scala.collection.mutable.LinkedHashMap.empty
Review Comment:
Shall we import `scala.collection.mutable` because we use at least 4 times
here in the above 4 lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
