uros-b commented on code in PR #56688:
URL: https://github.com/apache/spark/pull/56688#discussion_r3462675226
##########
sql/connect/client/jdbc/src/test/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaDataSuite.scala:
##########
@@ -808,4 +808,100 @@ class SparkConnectDatabaseMetaDataSuite extends
ConnectFunSuite with RemoteSpark
}
}
}
+
+ test("SparkConnectDatabaseMetaData getPrimaryKeys") {
+ withConnection { conn =>
+ val metadata = conn.getMetaData
+ // Spark has no primary keys, so an empty result set with the JDBC
schema is returned.
+ Using.resource(metadata.getPrimaryKeys(null, null, null)) { rs =>
+ val rsmd = rs.getMetaData
+ assert((1 to rsmd.getColumnCount).map(rsmd.getColumnName) === Seq(
+ "TABLE_CAT", "TABLE_SCHEM", "TABLE_NAME", "COLUMN_NAME", "KEY_SEQ",
"PK_NAME"))
+ assert(!rs.next())
+ }
+ }
+ }
+
+ test("SparkConnectDatabaseMetaData getImportedKeys and getExportedKeys") {
+ withConnection { conn =>
+ val metadata = conn.getMetaData
+ val foreignKeySchema = Seq(
+ "PKTABLE_CAT", "PKTABLE_SCHEM", "PKTABLE_NAME", "PKCOLUMN_NAME",
+ "FKTABLE_CAT", "FKTABLE_SCHEM", "FKTABLE_NAME", "FKCOLUMN_NAME",
+ "KEY_SEQ", "UPDATE_RULE", "DELETE_RULE", "FK_NAME", "PK_NAME",
"DEFERRABILITY")
+ // Spark has no foreign keys, so both return an empty result set with
the JDBC schema.
+ Seq(
+ () => metadata.getImportedKeys(null, null, null),
+ () => metadata.getExportedKeys(null, null, null)).foreach {
getForeignKeys =>
+ Using.resource(getForeignKeys()) { rs =>
+ val rsmd = rs.getMetaData
+ assert((1 to rsmd.getColumnCount).map(rsmd.getColumnName) ===
foreignKeySchema)
+ assert(!rs.next())
+ }
+ }
+ }
+ }
+
+ test("SparkConnectDatabaseMetaData getTypeInfo") {
+ withConnection { conn =>
+ val metadata = conn.getMetaData
+ Using.resource(metadata.getTypeInfo) { rs =>
+ val rsmd = rs.getMetaData
+ assert((1 to rsmd.getColumnCount).map(rsmd.getColumnName) === Seq(
Review Comment:
The getTypeInfo test asserts only the column names, not the per-row
LITERAL_PREFIX/types, so it would not have caught the BINARY prefix bug above
(https://github.com/apache/spark/pull/56688/changes#r3462660942). Strengthening
it to assert the literal prefixes/data types would lock in fidelity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
