HyukjinKwon opened a new pull request, #56720:
URL: https://github.com/apache/spark/pull/56720

   ### What changes were proposed in this pull request?
   [SPARK-57575](https://issues.apache.org/jira/browse/SPARK-57575) added two 
`TIME`-type `to_char`/`to_varchar` queries to `datetime-formatting.sql` and 
regenerated `datetime-formatting.sql.out` and 
`datetime-formatting-legacy.sql.out`, but not the Java 21 variant 
`datetime-formatting.sql.out.java21`. This PR regenerates the Java 21 golden by 
appending the two new `TIME`-type query blocks (their `HH:mm:ss` output is not 
locale/JDK sensitive, so it matches the default golden), restoring the expected 
36 query blocks.
   
   ### Why are the changes needed?
   `SQLQueryTestSuite` uses the `.out.java21` golden for any JDK >= 21, so the 
stale file breaks the scheduled **Maven (Scala 2.13, JDK 21)** and **Maven 
(Scala 2.13, JDK 25)** builds:
   
   ```
   datetime-formatting.sql
   Expected 109, but got 103 blocks in result file 
'datetime-formatting.sql.out.java21'. Try regenerating the result files.
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   No. Test-only.
   
   ### How was this patch tested?
   - **Before (failing job):** [`Build / Maven (Scala 2.13, JDK 21)` → 
`sql#core - extended 
tests`](https://github.com/apache/spark/actions/runs/28035705490/job/82998279873)
 — `datetime-formatting.sql *** FAILED ***`.
   - **After (passing):** ran `sql/testOnly 
org.apache.spark.sql.SQLQueryTestSuite -- -z datetime-formatting` on JDK 21 → 
[✅ all tests 
passed](https://github.com/HyukjinKwon/spark/actions/runs/28065758228/job/83089561688)
 (`Tests: succeeded 6, failed 0`).
   
   ### Was this patch authored or co-authored using generative AI tooling?
   Generated-by: Claude Opus 4.8
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to