jerrypeng commented on code in PR #56387:
URL: https://github.com/apache/spark/pull/56387#discussion_r3464857702
##########
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java:
##########
@@ -301,8 +304,12 @@ public void onFailure(Throwable e) {
*
* @param message The message to send.
*/
- public void send(ByteBuffer message) {
- channel.writeAndFlush(new OneWayMessage(new NioManagedBuffer(message)));
+ public ChannelFuture send(ByteBuffer message) {
Review Comment:
It want scenario would this actually cause an issue though? I understand if
this was an user facing interface for like one to use to implement a connector
or udf it could break users implementation if they compiled with an older
version of the interface. However, for this, it is unlikely someone will use a
different version of this module from the rest of spark right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
