aokolnychyi commented on code in PR #56619:
URL: https://github.com/apache/spark/pull/56619#discussion_r3464897567
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryBaseTable.scala:
##########
@@ -916,32 +907,60 @@ abstract class InMemoryBaseTable(
object InMemoryBaseTable {
private val columnIdGlobalCounter = new AtomicLong(0)
def nextColumnId(): Long = columnIdGlobalCounter.incrementAndGet()
-
- private def normalize(name: String): String = name.toLowerCase(Locale.ROOT)
+ def nextColumnIdString(): String = nextColumnId().toString
/**
- * Preserves column IDs from `oldColumns` when the column name matches,
- * and assigns new IDs to columns that do not already have one.
+ * Assigns fresh IDs to any top-level column or nested struct field that
does not already
+ * have one. Recurses into struct fields within ArrayType and MapType so
that every field
+ * at every depth gets an ID.
*
- * IDs are preserved across type changes, keeping the same column ID through
type
- * widening and nested field additions.
[[TypeChangeResetsColIdTableCatalog]] overrides
- * this behavior for testing scenarios where type changes should produce a
new ID.
+ * Existing IDs are preserved: Column → StructType → Column round-trip
encodes them in
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
