HyukjinKwon commented on PR #56722:
URL: https://github.com/apache/spark/pull/56722#issuecomment-4786384820
## Automated code review (ReviewFlow / `isaac review`)
Ran a multi-reviewer pass (logical + dead-code reviewers, 3 adaptive runs)
over this PR's diff
(2 files, +21/-2):
| Severity | Critical | Major | Minor | Info | Total |
|----------|:--------:|:-----:|:-----:|:----:|:-----:|
| Findings | 0 | 0 | 0 | 0 | **0** |
**No issues found** in the changed files
(`sql/connect/server/.../PythonPipelineSuite.scala`,
`sql/core/.../ManifestFileCommitProtocol.scala`).
Notes from manual double-check:
- The test change is data-only (retarget `standalone_flow1` to its own `st2`
table + a
`create_streaming_table` call added *below* the asserted lines), so the
source-code-location
assertions are unaffected — confirmed by **10× repeat runs** of
`PythonPipelineSuite` on CI
(106/106 each):
https://github.com/HyukjinKwon/spark/actions/runs/28074747108
- The `ManifestFileCommitProtocol` change is diagnostics-only (richer log +
exception message on an
already-existing race); no behavioral change.
Verdict: no blocking issues. Posting as a comment, not an approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
