gaoyajun02 commented on code in PR #56559:
URL: https://github.com/apache/spark/pull/56559#discussion_r3465176107
##########
core/src/main/scala/org/apache/spark/storage/PushBasedFetchHelper.scala:
##########
@@ -166,9 +165,16 @@ private class PushBasedFetchHelper(
meta: MergedBlockMeta): Unit = {
logDebug(s"Received the meta of push-merged block for ($shuffleId,
$shuffleMergeId," +
s" $reduceId) from ${req.address.host}:${req.address.port}")
+ val mergedBlock = ShuffleMergedBlockId(shuffleId, shuffleMergeId,
reduceId)
try {
-
iterator.addToResultsQueue(PushMergedRemoteMetaFetchResult(shuffleId,
shuffleMergeId,
- reduceId, sizeMap((shuffleId, reduceId)), meta.readChunkBitmaps(),
address))
+ val chunkBitmaps = meta.readChunkBitmaps().toIndexedSeq
Review Comment:
Good catch — reused the already-read `chunkBitmaps` variable instead of
calling `meta.readChunkBitmaps()` / `chunksMeta.readChunkBitmaps()` a second
time when constructing the fetch result. This was a partial fix in the previous
commit; now fully cleaned up for both remote and local meta paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
