uros-b commented on code in PR #56617:
URL: https://github.com/apache/spark/pull/56617#discussion_r3466218049
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/SupportsCatalogOptionsSuite.scala:
##########
@@ -443,3 +494,13 @@ class CatalogSupportingInMemoryTableProvider
}
}
}
+
+/** Opts out of catalog resolution, so load/save fall back to the plain
TableProvider path. */
+class CatalogResolutionOptOutProvider extends
CatalogSupportingInMemoryTableProvider {
+ override def useCatalogResolution(options: CaseInsensitiveStringMap):
Boolean = false
+}
+
+/** Opts out of failing on a missing table, enabling create-on-write for
save(). */
+class CreateOnWriteProvider extends CatalogSupportingInMemoryTableProvider {
+ override def failWriteIfTableDoesNotExist(options:
CaseInsensitiveStringMap): Boolean = false
+}
Review Comment:
Nit: missing @since on the new methods. Neither useCatalogResolution nor
failWriteIfTableDoesNotExist carries a @since tag (would be 4.3.0). Shall we
consider adding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
