uros-b commented on code in PR #56726:
URL: https://github.com/apache/spark/pull/56726#discussion_r3466633209
##########
python/pyspark/sql/column.py:
##########
@@ -1150,6 +1150,41 @@ def name(self, *alias: str, **kwargs: Any) -> "Column":
"""
...
+ @property
+ def _name(self) -> str:
Review Comment:
Note: leading-underscore name on a documented, versionadded-tagged public
API is a design smell (private by Python convention yet appears in
docs/tab-completion). The collision-avoidance motivation vs Column.name is
real, but an alternative (col_name / expr_name) would be cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
