MaxGekk commented on code in PR #56733: URL: https://github.com/apache/spark/pull/56733#discussion_r3467400324
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala: ########## @@ -3066,6 +3066,83 @@ case class MakeTimestampNTZNanos(left: Expression, right: Expression, precision: } } +/** Review Comment: On `MakeTimestampNTZNanos` — I don't think it needs the override: unlike the two LTZ builders it does **not** mix in `TimeZoneAwareExpression` (it's `BinaryExpression with RuntimeReplaceable with ExpectsInputTypes`). So there's no `final override val nodePatterns` from `TimeZoneAwareExpression` to swallow the pattern — it inherits `Seq(RUNTIME_REPLACEABLE)` straight from the `RuntimeReplaceable` trait, and `nodePatterns` already contains it. Adding the override there would be a redundant no-op. The issue is specifically the `RuntimeReplaceable` + `TimeZoneAwareExpression` combination, which is why only the LTZ builders (and the existing `ParseToDate` / `ParseToTimestamp` / `MakeTimestampFromDateTime`) need it. Happy to add it anyway if you'd prefer it purely for visual symmetry, but I'd lean toward leaving it as-is to avoid implying a dependency that isn't there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
