uros-b commented on code in PR #56742:
URL: https://github.com/apache/spark/pull/56742#discussion_r3467875291
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/pipelines/PipelineEventSenderSuite.scala:
##########
@@ -230,4 +235,107 @@ class PipelineEventSenderSuite extends
SparkDeclarativePipelinesServerTest with
eventSender.shutdown()
}
}
+
+ test("PipelineEventSender logs a warning when it drops events due to a full
queue") {
Review Comment:
Test could be hardened a bit: suppression relies on two back-to-back
sendEvent calls landing inside the default 60s throttle window. The test
asserts the correct expected count (==1) and cannot false-pass under any
realistic in-process execution (two calls never span 60s). Overriding
droppedEventLogIntervalMs to Long.MaxValue would make suppression structural
rather than timing-dependent (the re-log test #2 already does the inverse via
Long.MinValue).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
