sarutak commented on code in PR #56694:
URL: https://github.com/apache/spark/pull/56694#discussion_r3468200020
##########
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js:
##########
@@ -765,6 +770,41 @@ function setupZoomAndPan(svg, zoomLayer) {
// provides the natural fit, and the zoom-layer has no transform, so no
// explicit transform is required here.
updateZoomLevelLabel(1);
+
+ // Remove d3-zoom's wheel listener (which is registered as non-passive and
+ // can block page scrolling) and replace it with a gated wrapper that only
+ // forwards Ctrl/Cmd+wheel to d3, letting unmodified scrolls pass through.
+ var d3WheelHandler = svg.on("wheel.zoom");
+ svg.on("wheel.zoom", null);
+ svgNode.addEventListener("wheel", function (e) {
+ if (e.ctrlKey || e.metaKey) {
+ // Forward to d3-zoom's original handler for zoom behavior
+ d3WheelHandler.call(this, e);
+ } else {
+ // Let the event propagate naturally for page scrolling and show hint
+ showZoomHint();
+ }
+ });
+}
+
+var zoomHintTimeout;
+function showZoomHint() {
+ var container = document.getElementById("plan-viz-graph");
+ if (!container) return;
+ var hint = document.getElementById("plan-viz-zoom-hint");
+ if (!hint) {
+ hint = document.createElement("div");
+ hint.id = "plan-viz-zoom-hint";
+ hint.className = "plan-viz-zoom-hint";
+ var isMac = /Mac|iPhone|iPad/.test(navigator.platform ||
navigator.userAgent);
Review Comment:
navigator.userAgentData.platform is the intended successor but it's only
available in Chromium-based browsers (not Firefox/Safari).
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/userAgentData#browser_compatibility
So we'd still need the navigator.userAgent fallback anyway. The current code
already falls back to userAgent when platform is unavailable, which covers the
eventual deprecation. I'll leave it as-is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
