MaxGekk commented on code in PR #56744: URL: https://github.com/apache/spark/pull/56744#discussion_r3470287830
########## sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TimestampNanosBenchmark.scala: ########## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.benchmark + +import org.apache.spark.benchmark.Benchmark +import org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{withDefaultTimeZone, LA} +import org.apache.spark.sql.internal.SQLConf + +/** + * Synthetic benchmark comparing the microsecond timestamp path against the nanosecond-precision + * timestamp types `TIMESTAMP_NTZ(p)` / `TIMESTAMP_LTZ(p)`, `p in [7, 9]` (umbrella SPARK-56822). + * + * Most groups pair the same operation over a microsecond timestamp and the nanosecond type, so the + * per-row delta of the nanos path (a 16-byte `TimestampNanosVal` = epochMicros:Long + + * nanosWithinMicro:Short carrier, vs a plain 8-byte Long) is read directly off adjacent rows. A few + * groups pair related operations instead: Cast includes the cross-casts (micros <-> nanos(9)) and a + * nanos-only narrowing (nanos(9) -> nanos(7)), and Datetime functions pairs `unix_micros` with the + * nanos-only `unix_nanos`. + * The areas where nanos is expected to diverge from micros: + * - hashing: two hash ops (hashInt(nanos, hashLong(micros))) vs one; Review Comment: Nit: the parentheses here are unbalanced — the two ops are `hashInt(nanos)` and `hashLong(micros)`. ```suggestion * - hashing: two hash ops (hashInt(nanos), hashLong(micros)) vs one; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
