uros-b commented on code in PR #56662:
URL: https://github.com/apache/spark/pull/56662#discussion_r3472450811


##########
sql/pipelines/src/test/scala/org/apache/spark/sql/pipelines/graph/ConnectValidPipelineSuite.scala:
##########
@@ -561,4 +563,102 @@ class ConnectValidPipelineSuite extends PipelineTest with 
SharedSparkSession {
       s"Flow ${identifier.unquotedString} has the wrong schema"
     )
   }
+
+  test("per-flow confs are visible to the analyzer but do not leak onto the 
run session") {
+    val key = "pipelines.test.flowConfIsolation"

Review Comment:
   pipelines.test.flowConfIsolation is probably fine for isolation testing, but 
using a real analyzer-visible conf (e.g. spark.sql.caseSensitive) would 
additionally show that analysis actually uses the isolated conf, not just that 
it is stored in the right place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to